Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [#3] Skip CI if PR title starts with 'WIP' #513

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[WIP] [#3] Skip CI if PR title starts with 'WIP' #513

wants to merge 14 commits into from

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 12, 2024 •
edited by elfenpiff
Loading

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #3

@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Nov 12, 2024
@elBoberido elBoberido changed the title [#3] Skip CI if PR title starts with 'WIP' [WIP] [#3] Skip CI if PR title starts with 'WIP' Nov 12, 2024
elfenpiff
elfenpiff previously approved these changes Nov 14, 2024
View reviewed changes
@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Nov 20, 2024
@elBoberido elBoberido changed the title [#3] Skip CI if PR title starts with 'WIP' [WIP] [#3] Skip CI if PR title starts with 'WIP' Nov 20, 2024
@elfenpiff
Copy link
Contributor

elfenpiff commented Nov 20, 2024 •
edited
Loading

@elBoberido I would like to merge this. Can we do this? But if you want to tweak it a bit more, could you then also add an entry into the FAQ_ICEORYX_DEVS.md file?

@elBoberido
Copy link
Member Author

@elfenpiff this does not work as expected. I'd like to be able to manually trigger the CI after the PT title changed but unfortunately, when the initially failed PR re-runs, it checks the old PR title and it is not possible to trigger the CI without having a dummy push after removing the [WIP]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfenpiff elfenpiff elfenpiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elBoberido @elfenpiff